Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Unified Diff: mojo/system/channel.cc

Issue 277083003: Mojo: (Theoretically) implement the read side of platform handle passing. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: asdf Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/system/channel.h ('k') | mojo/system/channel_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/system/channel.cc
diff --git a/mojo/system/channel.cc b/mojo/system/channel.cc
index 32f56e1d9a2926fc4df1fe96e5d9ba3fe37dd76e..228c441e214be96824c49ca99723bb60de70b7e7 100644
--- a/mojo/system/channel.cc
+++ b/mojo/system/channel.cc
@@ -273,10 +273,6 @@ Channel::~Channel() {
}
void Channel::OnReadMessage(const MessageInTransit::View& message_view) {
- // Note: |ValidateReadMessage()| will call |HandleRemoteError()| if necessary.
- if (!ValidateReadMessage(message_view))
- return;
-
switch (message_view.type()) {
case MessageInTransit::kTypeMessagePipeEndpoint:
case MessageInTransit::kTypeMessagePipe:
@@ -298,17 +294,6 @@ void Channel::OnFatalError(FatalError fatal_error) {
Shutdown();
}
-bool Channel::ValidateReadMessage(const MessageInTransit::View& message_view) {
- const char* error_message = NULL;
- if (!message_view.IsValid(&error_message)) {
- DCHECK(error_message);
- HandleRemoteError(error_message);
- return false;
- }
-
- return true;
-}
-
void Channel::OnReadMessageForDownstream(
const MessageInTransit::View& message_view) {
DCHECK(message_view.type() == MessageInTransit::kTypeMessagePipeEndpoint ||
« no previous file with comments | « mojo/system/channel.h ('k') | mojo/system/channel_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698