Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Unified Diff: third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp

Issue 2770763002: [SPv2] Don't paint invisible PaintLayers with transform animations. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
diff --git a/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp b/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
index 69ea1ba78a717d723c57f53e1e0991dc341bc357..23abda1d2fd1c7c1b84b6af289d469245cd5c659 100644
--- a/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
+++ b/third_party/WebKit/Source/core/paint/PaintLayerPainterTest.cpp
@@ -1083,7 +1083,7 @@ TEST_P(PaintLayerPainterTest, DoPaintWithEffectAnimationZeroOpacity) {
PaintLayerPainter(*targetLayer).paintedOutputInvisible(paintingInfo));
}
-TEST_P(PaintLayerPainterTest, DoPaintWithTransformAnimationZeroOpacity) {
+TEST_P(PaintLayerPainterTest, DoNotPaintWithTransformAnimationZeroOpacity) {
setBodyInnerHTML(
"<style> "
"div#target { "
@@ -1101,8 +1101,13 @@ TEST_P(PaintLayerPainterTest, DoPaintWithTransformAnimationZeroOpacity) {
toLayoutBox(getLayoutObjectByElementId("target"))->layer();
PaintLayerPaintingInfo paintingInfo(nullptr, LayoutRect(),
GlobalPaintNormalPhase, LayoutSize());
- EXPECT_FALSE(
- PaintLayerPainter(*targetLayer).paintedOutputInvisible(paintingInfo));
+ if (RuntimeEnabledFeatures::slimmingPaintV2Enabled()) {
+ EXPECT_TRUE(
+ PaintLayerPainter(*targetLayer).paintedOutputInvisible(paintingInfo));
+ } else {
+ EXPECT_FALSE(
+ PaintLayerPainter(*targetLayer).paintedOutputInvisible(paintingInfo));
+ }
}
} // namespace blink
« no previous file with comments | « third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698