[base/files] Respect MAC_CHROMIUM_TMPDIR instead of TMPDIR on macOS.

base/files/file_util_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#include "base/files/file_util.h"
-
 #import <Foundation/Foundation.h>
 #include <copyfile.h>
 #include <stdlib.h>
 
 #include "base/files/file_path.h"
+#include "base/files/file_util.h"

[Mark Mentovai, 2017/03/28 00:20:23]

This was correct where it was before.

[iannucci, 2017/03/28 00:24:04]

Presumit was hollering at me about this (my original patchset had it above the
system imports).

[Mark Mentovai, 2017/03/28 00:27:14]

Presubmit’s wrong, NOPRESUBMIT it if you have to, and we can figure out how to
fix it.

+#include "base/logging.h"
 #include "base/mac/foundation_util.h"
 #include "base/strings/string_util.h"
 #include "base/threading/thread_restrictions.h"
 
 namespace base {
 
 bool CopyFile(const FilePath& from_path, const FilePath& to_path) {
   ThreadRestrictions::AssertIOAllowed();
   if (from_path.ReferencesParent() || to_path.ReferencesParent())
     return false;
   return (copyfile(from_path.value().c_str(),
                    to_path.value().c_str(), NULL, COPYFILE_DATA) == 0);
 }
 
 bool GetTempDir(base::FilePath* path) {
-  // In order to facilitate hermetic runs on macOS, first check $TMPDIR.
-  // NOTE: $TMPDIR is ALMOST ALWAYS set on macOS (unless the user un-set it).
-  const char* env_tmpdir = getenv("TMPDIR");
+  // In order to facilitate hermetic runs on macOS, first check
+  // $MAC_CHROMIUM_TMPDIR. We check this instead of $TMPDIR because external
+  // programs currently set $TMPDIR with no effect, but when we respect it
+  // directly it can cause crashes (like crbug.com/698759).
+  const char* env_tmpdir = getenv("MAC_CHROMIUM_TMPDIR");
   if (env_tmpdir) {
+    DCHECK_LT(strlen(env_tmpdir), 50)

[iannucci, 2017/03/28 00:10:59]

NSTemporaryDirectory() length is 49.

[Mark Mentovai, 2017/03/28 00:20:23]

#inclue <string.h> for this.

[iannucci, 2017/03/28 00:24:04]

er... whoops.

+        << "too-long TMPDIR causes socket name length issues.";
     *path = base::FilePath(env_tmpdir);
     return true;
   }
 
   // If we didn't find it, fall back to the native function.
   NSString* tmp = NSTemporaryDirectory();
   if (tmp == nil)
     return false;
   *path = base::mac::NSStringToFilePath(tmp);
   return true;
@@ skipping 10 matching lines @@
   // Fall back on temp dir if no home directory is defined.
   FilePath rv;
   if (GetTempDir(&rv))
     return rv;
 
   // Last resort.
   return FilePath("/tmp");
 }
 
 }  // namespace base