Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(644)

Side by Side Diff: src/debug/debug-evaluate.cc

Issue 2770753003: Migrate Object constructor to C++
Patch Set: Ack comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/js/v8natives.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 the V8 project authors. All rights reserved. 1 // Copyright 2015 the V8 project authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "src/debug/debug-evaluate.h" 5 #include "src/debug/debug-evaluate.h"
6 6
7 #include "src/accessors.h" 7 #include "src/accessors.h"
8 #include "src/compiler.h" 8 #include "src/compiler.h"
9 #include "src/contexts.h" 9 #include "src/contexts.h"
10 #include "src/debug/debug-frames.h" 10 #include "src/debug/debug-frames.h"
(...skipping 397 matching lines...) Expand 10 before | Expand all | Expand 10 after
408 Bytecodes::ToString(bytecode)); 408 Bytecodes::ToString(bytecode));
409 } 409 }
410 return false; 410 return false;
411 } 411 }
412 } 412 }
413 413
414 bool BuiltinHasNoSideEffect(Builtins::Name id) { 414 bool BuiltinHasNoSideEffect(Builtins::Name id) {
415 switch (id) { 415 switch (id) {
416 // Whitelist for builtins. 416 // Whitelist for builtins.
417 // Object builtins. 417 // Object builtins.
418 case Builtins::kObjectConstructor:
418 case Builtins::kObjectCreate: 419 case Builtins::kObjectCreate:
419 case Builtins::kObjectEntries: 420 case Builtins::kObjectEntries:
420 case Builtins::kObjectGetOwnPropertyDescriptor: 421 case Builtins::kObjectGetOwnPropertyDescriptor:
421 case Builtins::kObjectGetOwnPropertyDescriptors: 422 case Builtins::kObjectGetOwnPropertyDescriptors:
422 case Builtins::kObjectGetOwnPropertyNames: 423 case Builtins::kObjectGetOwnPropertyNames:
423 case Builtins::kObjectGetOwnPropertySymbols: 424 case Builtins::kObjectGetOwnPropertySymbols:
424 case Builtins::kObjectGetPrototypeOf: 425 case Builtins::kObjectGetPrototypeOf:
425 case Builtins::kObjectIs: 426 case Builtins::kObjectIs:
426 case Builtins::kObjectIsExtensible: 427 case Builtins::kObjectIsExtensible:
427 case Builtins::kObjectIsFrozen: 428 case Builtins::kObjectIsFrozen:
(...skipping 218 matching lines...) Expand 10 before | Expand all | Expand 10 after
646 647
647 if (FLAG_trace_side_effect_free_debug_evaluate) { 648 if (FLAG_trace_side_effect_free_debug_evaluate) {
648 PrintF("[debug-evaluate] API Callback at %p may cause side effect.\n", 649 PrintF("[debug-evaluate] API Callback at %p may cause side effect.\n",
649 reinterpret_cast<void*>(function_addr)); 650 reinterpret_cast<void*>(function_addr));
650 } 651 }
651 return false; 652 return false;
652 } 653 }
653 654
654 } // namespace internal 655 } // namespace internal
655 } // namespace v8 656 } // namespace v8
OLDNEW
« no previous file with comments | « src/crankshaft/hydrogen.cc ('k') | src/js/v8natives.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698