Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(141)

Issue 2770713008: Automation API: Get rid of host node and get parent from C++ bindings instead

Created:
3 years, 9 months ago by dmazzoni
Modified:
3 years, 9 months ago
Reviewers:
David Tseng
CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Automation API: Get rid of host node and get parent from C++ bindings instead This is just a refactoring, it's slightly less fragile to have all of the code to walk "up" trees in one place rather than in both C++ and in JS automation bindings. BUG=none

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -34 lines) Patch
M chrome/renderer/extensions/automation_internal_custom_bindings.cc View 1 1 chunk +9 lines, -4 lines 0 comments Download
M chrome/renderer/resources/extensions/automation/automation_node.js View 8 chunks +14 lines, -26 lines 0 comments Download
M chrome/renderer/resources/extensions/automation_custom_bindings.js View 2 chunks +0 lines, -4 lines 0 comments Download

Depends on Patchset:

Messages

Total messages: 8 (5 generated)
dmazzoni
3 years, 9 months ago (2017-03-23 23:11:32 UTC) #2
David Tseng
Please try to retain the idea behind the js bindings when converting into native. i.e. ...
3 years, 9 months ago (2017-03-24 21:38:12 UTC) #3
David Tseng
3 years, 9 months ago (2017-03-24 21:40:48 UTC) #4
Automation API: Get rid of host node and get parent from C++ bindings instead

Please rephrase; there's a 'and use' probably left out or something.

Powered by Google App Engine
This is Rietveld 408576698