Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1792)

Unified Diff: android_webview/renderer/aw_print_web_view_helper_delegate.cc

Issue 2770713003: Enable page selection for WebView printing (Closed)
Patch Set: enable IsAskPrintSettingsEnabled Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: android_webview/renderer/aw_print_web_view_helper_delegate.cc
diff --git a/android_webview/renderer/aw_print_web_view_helper_delegate.cc b/android_webview/renderer/aw_print_web_view_helper_delegate.cc
index ccb7b2afad1728ff35e7ca71224e5c533e3891ac..2eb7214e3cedc7bf5e0dcf2c9ec78514eadae350 100644
--- a/android_webview/renderer/aw_print_web_view_helper_delegate.cc
+++ b/android_webview/renderer/aw_print_web_view_helper_delegate.cc
@@ -25,7 +25,7 @@ bool AwPrintWebViewHelperDelegate::IsPrintPreviewEnabled() {
}
bool AwPrintWebViewHelperDelegate::IsAskPrintSettingsEnabled() {
- return false;
+ return true;
sgurun-gerrit only 2017/03/23 19:16:59 two comments: I think this is to enable browser a
Lei Zhang 2017/03/23 19:35:18 Yes, that was the original intent, but this is fin
sgurun-gerrit only 2017/03/23 19:38:18 alright then, no worries about updating comment.
Shimi Zhang 2017/03/23 23:21:56 Done.
}
bool AwPrintWebViewHelperDelegate::IsScriptedPrintEnabled() {
« android_webview/native/aw_pdf_exporter.cc ('K') | « android_webview/native/aw_pdf_exporter.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698