Rename SecurityStyleExplanations and WebSecurityStyle fields

content/public/browser/security_style_explanations.h

Index: content/public/browser/security_style_explanations.h
diff --git a/content/public/browser/security_style_explanations.h b/content/public/browser/security_style_explanations.h
index 3033c2a10a718495275b8db71a4fda8f8af3c9df..f7cc76302be375f8199baf967f7205807a71ee8f 100644
--- a/content/public/browser/security_style_explanations.h
+++ b/content/public/browser/security_style_explanations.h
@@ -23,8 +23,8 @@ namespace content {
 // SecurityStyleExplanation is a single security property of a page (for
 // example, an expired certificate, a valid certificate, or the presence
 // of a deprecated crypto algorithm). A single site may have multiple
-// different explanations of "secure", "warning", "broken", and "info" severity
-// levels.
+// different explanations of "secure", "warning", "insecure", and "info"
+// severity levels.
 struct SecurityStyleExplanations {
   CONTENT_EXPORT SecurityStyleExplanations();
   CONTENT_EXPORT SecurityStyleExplanations(
@@ -69,11 +69,21 @@ struct SecurityStyleExplanations {
   // the style cannot be determined from HTTPS status alone.
   std::string summary;
 
-  // Explanations corresponding to each security level. The embedder should
-  // display explanations in the order: broken, unauthenticated, secure, info.
+  // Explanations corresponding to each security level.

[estark, 2017/03/22 17:32:27]

(removed the instruction about how to display explanations because I think that
should be really be up to the UI layer, not this code's concern)

+
+  // |secure_explanations| explains why the page was marked secure.
   std::vector<SecurityStyleExplanation> secure_explanations;
-  std::vector<SecurityStyleExplanation> unauthenticated_explanations;
-  std::vector<SecurityStyleExplanation> broken_explanations;
+  // |neutral_explanations| explains why the page was marked neutrally: for
+  // example, the page's lock icon was taken away due to mixed content, or the
+  // page was not loaded over HTTPS.
+  std::vector<SecurityStyleExplanation> neutral_explanations;
+  // |insecure_explanations| explains why the page was marked as insecure or
+  // dangerous: for example, the page was loaded with a certificate error.
+  std::vector<SecurityStyleExplanation> insecure_explanations;
+  // |info_explanations| contains information that did not affect the page's
+  // security style, but is still relevant to the page's security state: for
+  // example, an upcoming deprecation that will affect the security style in
+  // future.
   std::vector<SecurityStyleExplanation> info_explanations;
 };