ui/gfx/image/mojo/image.typemap - Issue 2770693002: ash: HiDPI user avatar for SessionController

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/gfx/image/mojo/image.typemap

Issue 2770693002: ash: HiDPI user avatar for SessionController (Closed)

Patch Set: fix compile Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 # Copyright 2017 The Chromium Authors. All rights reserved.

	2 # Use of this source code is governed by a BSD-style license that can be

	3 # found in the LICENSE file.

	4

	5 mojom = "//ui/gfx/image/mojo/image.mojom"

	6 public_headers = [

	7 "//third_party/skia/include/core/SkBitmap.h",

	8 "//ui/gfx/image/image_skia_rep.h",

	9 "//ui/gfx/image/image_skia.h",

	10 ]

	11 traits_headers = [ "//ui/gfx/image/mojo/image_skia_struct_traits.h" ]

	12 public_deps = [

	13 "//ui/gfx/image/mojo:struct_traits",

	14 ]

	15 type_mappings = [

	16 "gfx.mojom.ImageSkia=gfx::ImageSkia[nullable_is_same_type]",

	17 "gfx.mojom.ImageSkiaRep=gfx::ImageSkiaRep[nullable_is_same_type]",

	18 "gfx.mojom.SharedBufferSkBitmap=SkBitmap[nullable_is_same_type]",
	msw 2017/03/24 17:59:32 Is there any worry in aliasing two mojom types to Is there any worry in aliasing two mojom types to one c++ type? xiyuan 2017/03/24 18:36:53 It seems to me that the mojo side must be unique b Show quoted text On 2017/03/24 17:59:32, msw wrote: > Is there any worry in aliasing two mojom types to one c++ type? It seems to me that the mojo side must be unique but C++ side does not have to be. The mojo template is smart enough to figure that out because it knows which mojo type will be used. And yes, we should move this into //skia, not only it is cleaner but also saves two memory copies. I will have a follow up CL, hopefully next week.
	19 ]

OLD	NEW