ash: HiDPI user avatar for SessionController

ui/gfx/image/mojo/image.mojom

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+module gfx.mojom;
+
+// Mojo transport for a SkBitmap via shared buffer.
+// TODO: Merge into bitmap.mojom in skia and maybe share pixel buffer directly
+//     to make less copies.

[msw, 2017/03/24 17:59:32]

optional nit: indent two more spaces?

[xiyuan, 2017/03/24 18:36:53]

Done.

+struct SharedBufferSkBitmap {
+  // Shared buffer handle to hold a serialized SkBitmap.
+  handle<shared_buffer> shared_buffer_handle;
+
+  // Byte size of the shared buffer.
+  uint64 buffer_byte_size;
+};
+
+// Mojo transport for an ImageSkiaRep using SharedBufferSkBitmap.
+struct ImageSkiaRep {
+  // Transport of the bitmap in this representation.
+  SharedBufferSkBitmap bitmap;
+
+  // Corresponding scale of the bitmap or 0 if unscaled.
+  float scale;
+};
+
+// Mojo transport for an ImageSkia via shared buffer. Note the ImageSkia would
+// be made thread-safe (all reps loaded and be immutable) after using this.

[msw, 2017/03/24 17:59:32]

Does calling EnsureRepsForSupportedScales actually make the ImageSkia immutable
and thread safe? I'm not sure about that.

[xiyuan, 2017/03/24 18:36:53]

Oops. Forgot to update this after switching back from MakeThreadSafe.
EnsureRepsForSupportedScales only loads the reps.

Comments changed.

+struct ImageSkia {
+  array<ImageSkiaRep> image_reps;
+};