Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(370)

Issue 2770683005: Only display 'nits' in verbose mode. (Closed)

Created:
3 years, 9 months ago by ahe
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry, karlklose
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rebased on master. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M pkg/front_end/lib/src/fasta/messages.dart View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
ahe
I mostly find nits helpful as a sanity check, and Paul pointed out that our ...
3 years, 9 months ago (2017-03-23 08:05:35 UTC) #2
karlklose
LGTM
3 years, 9 months ago (2017-03-23 08:38:29 UTC) #3
ahe
3 years, 9 months ago (2017-03-23 11:34:40 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
bfb82582f57f154af24a1b63528b630b102c373c (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698