[DevTools] Fix Popover click handling.

third_party/WebKit/Source/devtools/front_end/ui/Popover.js

 /*
  * Copyright (C) 2009 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 69 matching lines @@
    * @return {boolean}
    */
   _eventInScheduledContent(event) {
     return this._scheduledRequest ? this._scheduledRequest.box.contains(event.clientX, event.clientY) : false;
   }
 
   /**
    * @param {!Event} event
    */
   _mouseDown(event) {
-    if (this._disableOnClick || !this._eventInScheduledContent(event)) {
+    if (this._disableOnClick) {
       this.hidePopover();
-    } else {
-      this._stopHidePopoverTimer();
-      this._stopShowPopoverTimer();
-      this._startShowPopoverTimer(event, 0);
+      return;
     }
+    if (this._eventInScheduledContent(event))
+      return;
+
+    this._startHidePopoverTimer(0);
+    this._stopShowPopoverTimer();
+    this._startShowPopoverTimer(event, 0);
   }
 
   /**
    * @param {!Event} event
    */
   _mouseMove(event) {
     // Pretend that nothing has happened.
     if (this._eventInScheduledContent(event))
       return;
 
-    this._startHidePopoverTimer();
+    this._startHidePopoverTimer(this._hideTimeout);
     this._stopShowPopoverTimer();
     if (event.which && this._disableOnClick)
       return;
     this._startShowPopoverTimer(
         event, this.isPopoverVisible() ? Math.max(this._timeout * 0.6, this._hideTimeout) : this._timeout);
   }
 
   /**
    * @param {!Event} event
    */
   _popoverMouseMove(event) {
     this._stopHidePopoverTimer();
   }
 
   /**
    * @param {!UI.GlassPane} popover
    * @param {!Event} event
    */
   _popoverMouseOut(popover, event) {
     if (!popover.isShowing())
       return;
     if (event.relatedTarget && !event.relatedTarget.isSelfOrDescendant(popover.contentElement))
-      this._startHidePopoverTimer();
+      this._startHidePopoverTimer(this._hideTimeout);
   }
 
   /**
    * @param {!Event} event
    */
   _mouseOut(event) {
     if (!this.isPopoverVisible())
       return;
     if (!this._eventInScheduledContent(event))
-      this._startHidePopoverTimer();
+      this._startHidePopoverTimer(this._hideTimeout);
   }
 
-  _startHidePopoverTimer() {
-    // User has this._hideTimeout to reach the popup.
+  /**
+   * @param {number} timeout
+   */
+  _startHidePopoverTimer(timeout) {
+    // User has |timeout| ms to reach the popup.
     if (!this._hidePopoverCallback || this._hidePopoverTimer)
       return;
 
     this._hidePopoverTimer = setTimeout(() => {
       this._hidePopover();
       delete this._hidePopoverTimer;
-    }, this._hideTimeout);
+    }, timeout);
   }
 
   /**
    * @param {!Event} event
    * @param {number} timeout
    */
   _startShowPopoverTimer(event, timeout) {
     this._scheduledRequest = this._getRequest.call(null, event);
     if (!this._scheduledRequest)
       return;
@@ skipping 79 matching lines @@
     delete this._hidePopoverTimer;
 
     // We know that we reached the popup, but we might have moved over other elements.
     // Discard pending command.
     this._stopShowPopoverTimer();
   }
 };
 
 /** @typedef {{box: !AnchorBox, show:(function(!UI.GlassPane):!Promise<boolean>), hide:(function()|undefined)}} */
 UI.PopoverRequest;