Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(914)

Issue 2770563002: Remove dead elements from the MemorySet in load elimination. (Closed)

Created:
3 years, 9 months ago by sra1
Modified:
3 years, 8 months ago
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove dead elements from the MemorySet in load elimination. The old code killed bindings by storing `null`. It is possible to construct straight-line code with takes time and space O(N^2) to do load elimination, since all the useless nulled-out bindings are re-walked on every killAffectedBy call. Luckily most of our generated code has some joins which cause the intersection to be computed which deletes the unused bindings. BUG= R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/8d62ce1042e5a4e395701afeb92c11431d4c8b80

Patch Set 1 #

Patch Set 2 : reuse list #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M pkg/compiler/lib/src/ssa/optimize.dart View 1 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
sra1
3 years, 9 months ago (2017-03-22 22:13:31 UTC) #2
sra1
3 years, 9 months ago (2017-03-23 19:03:47 UTC) #3
Siggi Cherem (dart-lang)
lgtm
3 years, 9 months ago (2017-03-23 19:29:17 UTC) #4
sra1
3 years, 8 months ago (2017-04-03 19:12:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
8d62ce1042e5a4e395701afeb92c11431d4c8b80 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698