Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(436)

Issue 277053003: Do FinishAllRendering in WM_WINDOWPOSCHANGING (Closed)

Created:
6 years, 7 months ago by jbauman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tdanderson+views_chromium.org, Ian Vollick, tfarina, sievers+watch_chromium.org, jbauman+watch_chromium.org, ben+views_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, cc-bugs_chromium.org
Visibility:
Public.

Description

Do FinishAllRendering in WM_WINDOWPOSCHANGING This ensures that the last swap completes before the window is resized, so that the window contents aren't scaled. BUG=363704 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270206

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+19 lines, -17 lines) Patch
M ui/compositor/compositor.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ui/compositor/compositor.cc View 4 chunks +4 lines, -15 lines 1 comment Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.h View 1 chunk +1 line, -0 lines 0 comments Download
M ui/views/widget/desktop_aura/desktop_window_tree_host_win.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M ui/views/win/hwnd_message_handler_delegate.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
jbauman
6 years, 7 months ago (2014-05-10 00:55:05 UTC) #1
cpu_(ooo_6.6-7.5)
lgtm adding iyengar for the hwmd message handler file. https://codereview.chromium.org/277053003/diff/1/ui/compositor/compositor.cc File ui/compositor/compositor.cc (left): https://codereview.chromium.org/277053003/diff/1/ui/compositor/compositor.cc#oldcode293 ui/compositor/compositor.cc:293: ...
6 years, 7 months ago (2014-05-10 02:36:23 UTC) #2
jbauman
On 2014/05/10 02:36:23, cpu wrote: > lgtm > > adding iyengar for the hwmd message ...
6 years, 7 months ago (2014-05-10 02:57:50 UTC) #3
jbauman
ben@, could I get an OWNERS review for this?
6 years, 7 months ago (2014-05-12 23:58:27 UTC) #4
Ben Goodger (Google)
lgtm
6 years, 7 months ago (2014-05-13 19:56:08 UTC) #5
jbauman
The CQ bit was checked by jbauman@chromium.org
6 years, 7 months ago (2014-05-13 20:07:10 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbauman@chromium.org/277053003/1
6 years, 7 months ago (2014-05-13 20:09:35 UTC) #7
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 21:27:52 UTC) #8
Message was sent while issue was closed.
Change committed as 270206

Powered by Google App Engine
This is Rietveld 408576698