Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2678)

Unified Diff: chrome/browser/notifications/notification_platform_bridge_mac.mm

Issue 2770523003: [Mac] Change the notification button drop down label (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification_platform_bridge_mac.mm
diff --git a/chrome/browser/notifications/notification_platform_bridge_mac.mm b/chrome/browser/notifications/notification_platform_bridge_mac.mm
index 9017890bf7aed012ac76c5bb23d71427c5ea5334..7b72d95953cd092bcc545298c8dcd5898b8936d6 100644
--- a/chrome/browser/notifications/notification_platform_bridge_mac.mm
+++ b/chrome/browser/notifications/notification_platform_bridge_mac.mm
@@ -179,10 +179,10 @@ void NotificationPlatformBridgeMac::Display(
const std::string& profile_id,
bool incognito,
const Notification& notification) {
- base::scoped_nsobject<NotificationBuilder> builder(
- [[NotificationBuilder alloc]
+ base::scoped_nsobject<NotificationBuilder> builder([
Robert Sesek 2017/03/22 14:35:25 Silly clang-format?
Miguel Garcia 2017/03/22 20:45:57 Yes in fact I had to bypass it because it kept ins
Miguel Garcia 2017/03/22 20:45:58 Yes in fact I had to bypass it because it kept ins
+ [NotificationBuilder alloc]
initWithCloseLabel:l10n_util::GetNSString(IDS_NOTIFICATION_BUTTON_CLOSE)
- optionsLabel:l10n_util::GetNSString(IDS_NOTIFICATION_BUTTON_OPTIONS)
+ optionsLabel:l10n_util::GetNSString(IDS_NOTIFICATION_BUTTON_MORE)
settingsLabel:l10n_util::GetNSString(
IDS_NOTIFICATION_BUTTON_SETTINGS)]);

Powered by Google App Engine
This is Rietveld 408576698