Issue 27705002: Experimental parser: Refactoring and timing.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27705002: Experimental parser: Refactoring and timing. (Closed)

Created:
7 years, 2 months ago by marja

Modified:
7 years, 2 months ago

Reviewers:
ulan

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/experimental/parser

Visibility:
Public.

More Reviews

Description

Experimental parser: Refactoring and timing. - Make it possible to read the whole file at once in the experimental scanner. - Add some timing code to measure how much scanning took. BUG= R=ulan@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=17256

Patch Set 1 #

Total comments: 2

Patch Set 2 : Code review (ulan) #

Patch Set 3 : Code review (ulan) #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+296 lines, -206 lines)			Patch
M	src/lexer/lexer.h	View		2 chunks	+44 lines, -7 lines	0 comments	Download
M	src/lexer/lexer.re	View		3 chunks	+141 lines, -182 lines	0 comments	Download
M	src/lexer/lexer-shell.cc	View	1	3 chunks	+111 lines, -17 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

ulan

LGTM https://codereview.chromium.org/27705002/diff/1/src/lexer/lexer-shell.cc File src/lexer/lexer-shell.cc (right): https://codereview.chromium.org/27705002/diff/1/src/lexer/lexer-shell.cc#newcode191 src/lexer/lexer-shell.cc:191: gettimeofday(&baseline_tv_start, NULL); We can use ElapsedTimer of v8 ...

7 years, 2 months ago (2013-10-17 13:43:32 UTC) #2

marja

https://codereview.chromium.org/27705002/diff/1/src/lexer/lexer-shell.cc File src/lexer/lexer-shell.cc (right): https://codereview.chromium.org/27705002/diff/1/src/lexer/lexer-shell.cc#newcode191 src/lexer/lexer-shell.cc:191: gettimeofday(&baseline_tv_start, NULL); On 2013/10/17 13:43:32, ulan wrote: > We ...

7 years, 2 months ago (2013-10-17 13:56:34 UTC) #3

marja

7 years, 2 months ago (2013-10-17 13:57:01 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 manually as r17256 (presubmit successful).

Expand Messages | Collapse Messages