Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(619)

Unified Diff: components/safe_browsing/renderer/threat_dom_details.cc

Issue 2770493004: Remove disable warnings compile flag in safebrowsing component, and fix some type win64 type errors… (Closed)
Patch Set: Sync Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/safe_browsing/renderer/BUILD.gn ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/renderer/threat_dom_details.cc
diff --git a/components/safe_browsing/renderer/threat_dom_details.cc b/components/safe_browsing/renderer/threat_dom_details.cc
index 90d70e48ba3d96ade60a5f4028d738d1db8d7aae..f6e1abefe0ee138a5d4f6c5c86804998c23a3421 100644
--- a/components/safe_browsing/renderer/threat_dom_details.cc
+++ b/components/safe_browsing/renderer/threat_dom_details.cc
@@ -109,7 +109,7 @@ SafeBrowsingHostMsg_ThreatDOMDetails_Node* GetNodeForElement(
const safe_browsing::ElementToNodeMap& element_to_node_map,
std::vector<SafeBrowsingHostMsg_ThreatDOMDetails_Node>* resources) {
DCHECK(element_to_node_map.count(element) > 0);
- int resource_index = element_to_node_map.at(element);
+ size_t resource_index = element_to_node_map.at(element);
return &(resources->at(resource_index));
}
@@ -171,7 +171,7 @@ void HandleElement(
// Update the ID mapping. First generate the ID for the current node.
// Then, if its parent is available, set the current node's parent ID, and
// also update the parent's children with the current node's ID.
- const size_t child_id = element_to_node_map->size() + 1;
+ const int child_id = static_cast<int>(element_to_node_map->size()) + 1;
child_node.node_id = child_id;
blink::WebNode cur_parent_element = element.parentNode();
while (!cur_parent_element.isNull()) {
« no previous file with comments | « components/safe_browsing/renderer/BUILD.gn ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698