Remove disable warnings compile flag in safebrowsing component, and fix some type win64 type errors…

components/safe_browsing/renderer/threat_dom_details.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/safe_browsing/renderer/threat_dom_details.h"
 
 #include <algorithm>
 #include <map>
 #include <unordered_set>
 
@@ skipping 91 matching lines @@
             [](const TagAndAttributesItem& a, const TagAndAttributesItem& b) {
               return a.tag_name < b.tag_name;
             });
 }
 
 SafeBrowsingHostMsg_ThreatDOMDetails_Node* GetNodeForElement(
     const blink::WebNode& element,
     const safe_browsing::ElementToNodeMap& element_to_node_map,
     std::vector<SafeBrowsingHostMsg_ThreatDOMDetails_Node>* resources) {
   DCHECK(element_to_node_map.count(element) > 0);
-  int resource_index = element_to_node_map.at(element);
+  size_t resource_index = element_to_node_map.at(element);
   return &(resources->at(resource_index));
 }
 
 std::string TruncateAttributeString(const std::string& input) {
   if (input.length() <= ThreatDOMDetails::kMaxAttributeStringLength) {
     return input;
   }
 
   std::string truncated;
   base::TruncateUTF8ToByteSize(
@@ skipping 41 matching lines @@
                          element.getAttribute(attr_webstring).ascii())));
       if (child_node.attributes.size() == ThreatDOMDetails::kMaxAttributes) {
         break;
       }
     }
   }
 
   // Update the ID mapping. First generate the ID for the current node.
   // Then, if its parent is available, set the current node's parent ID, and
   // also update the parent's children with the current node's ID.
-  const size_t child_id = element_to_node_map->size() + 1;
+  const int child_id = static_cast<int>(element_to_node_map->size()) + 1;

[Nathan Parker, 2017/03/22 21:12:56]

Why cast to int?  I'm not confident I know which is safer, since an overflow
here would turn negative, which may have bad effects.

[lpz, 2017/03/23 15:37:32]

The alternative would be to keep size_t here but then the IPC message fields
will have to be changed to size_t, which is a blacklisted IPC type apparently. I
could cast to ints before setting the IPC fields, but seems easier to do it
here.

Note also that the size of this map is capped by kMaxNodes, which is currently
at 500, so at least some control from overflows.

   child_node.node_id = child_id;
   blink::WebNode cur_parent_element = element.parentNode();
   while (!cur_parent_element.isNull()) {
     if (element_to_node_map->count(cur_parent_element) > 0) {
       SafeBrowsingHostMsg_ThreatDOMDetails_Node* parent_node =
           GetNodeForElement(cur_parent_element, *element_to_node_map,
                             resources);
       child_node.parent_node_id = parent_node->node_id;
       parent_node->child_node_ids.push_back(child_id);
 
@@ skipping 113 matching lines @@
     }
   }
   resources->push_back(details_node);
 }
 
 void ThreatDOMDetails::OnDestruct() {
   delete this;
 }
 
 }  // namespace safe_browsing