Issue 2770493003: fixes #29095, machine mode escapes newline/returns - Code Review

Chromium Code Reviews

chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out

(9)

My Issues | Starred Open | Closed | All

Issue 2770493003: fixes #29095, machine mode escapes newline/returns (Closed)

Created:
3 years, 9 months ago by Jennifer Messerly

Modified:
3 years, 9 months ago

Reviewers:
skybrian, pquitslund

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

fixes #29095, machine mode escapes newline/returns R=skybrian@google.com Committed: https://github.com/dart-lang/sdk/commit/f3f814b89976510e5b4a3c5e39679c46a781e546

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+14 lines, -6 lines)			Patch
	M	pkg/analyzer_cli/lib/src/error_formatter.dart	View		4 chunks	+14 lines, -6 lines	0 comments	Download

Messages

Total messages: 7 (3 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jennifer Messerly

Committed patchset #1 (id:1) manually as f3f814b89976510e5b4a3c5e39679c46a781e546 (presubmit successful).

3 years, 9 months ago (2017-03-22 02:31:44 UTC) #6

Message was sent while issue was closed.

Late to the party, but LGTM!

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Powered by Google App Engine

This is Rietveld 408576698