third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h - Issue 2770483002: CS of out-of-flow positioned objects should have is_new_fc == true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

Issue 2770483002: CS of out-of-flow positioned objects should have is_new_fc == true (Closed)

Patch Set: fix comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_floats_utils.cc ('K') | « third_party/WebKit/Source/core/layout/ng/ng_floats_utils.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

index 8a8eeaed78602819ffb910ad9ea4a05c480ca5ec..cabc6106ee511dcca0a2a4c487df2f89f7790b68 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

+++ b/third_party/WebKit/Source/core/layout/ng/ng_layout_opportunity_iterator.h

@@ -31,6 +31,7 @@ class CORE_EXPORT NGLayoutOpportunityIterator final {

// represent a text fragment for example.

NGLayoutOpportunityIterator(

const NGConstraintSpace* space,

+ const NGLogicalSize& available_size,

const WTF::Optional<NGLogicalOffset>& opt_offset = WTF::nullopt,

const WTF::Optional<NGLogicalOffset>& opt_leader_point = WTF::nullopt);