Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc

Issue 2770483002: CS of out-of-flow positioned objects should have is_new_fc == true (Closed)
Patch Set: update TestExpectations Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
index dc91de25eeec2db6f4066f9beebf6bcccb38af3b..dfbcd720bc75c0f2b6f05124c882125eef21114e 100644
--- a/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
+++ b/third_party/WebKit/Source/core/layout/ng/ng_line_builder.cc
@@ -36,7 +36,7 @@ RefPtr<NGConstraintSpace> CreateConstraintSpaceForFloat(
NGConstraintSpaceBuilder* space_builder) {
DCHECK(space_builder) << "space_builder cannot be null here";
bool is_new_bfc =
- IsNewFormattingContextForInFlowBlockLevelChild(parent_space, style);
+ IsNewFormattingContextForBlockLevelChild(parent_space, style);
return space_builder->SetIsNewFormattingContext(is_new_bfc)
.SetTextDirection(style.direction())
.SetIsShrinkToFit(ShouldShrinkToFit(parent_space, style))
@@ -326,7 +326,7 @@ void NGLineBuilder::LayoutAndPositionFloat(LayoutUnit end_position,
RefPtr<NGFloatingObject> floating_object = NGFloatingObject::Create(
float_space.get(), constraint_space_, node->Style(), NGBoxStrut(),
- layout_result->PhysicalFragment().get());
+ current_opportunity_.size, layout_result->PhysicalFragment().get());
bool float_does_not_fit = end_position + float_fragment.InlineSize() >
current_opportunity_.InlineSize();

Powered by Google App Engine
This is Rietveld 408576698