CS of out-of-flow positioned objects should have is_new_fc == true

third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc

Index: third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc
diff --git a/third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc b/third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..2b75770abfdeeea4d51d471265115e7937050cc6
--- /dev/null
+++ b/third_party/WebKit/Source/core/layout/ng/ng_space_utils_test.cc
@@ -0,0 +1,47 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "core/layout/ng/ng_space_utils.h"
+
+#include "core/layout/ng/ng_constraint_space.h"
+#include "core/layout/ng/ng_constraint_space_builder.h"
+#include "core/style/ComputedStyle.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blink {
+namespace {
+
+class NGSpaceUtilsTest : public ::testing::Test {
+ protected:
+  NGSpaceUtilsTest() : space_builder_(NGWritingMode::kHorizontalTopBottom) {}
+
+  void SetUp() override { style_ = ComputedStyle::create(); }
+  RefPtr<ComputedStyle> style_;
+  NGConstraintSpaceBuilder space_builder_;
+};
+
+// Verifies that IsNewFormattingContextForInFlowBlockLevelChild returnes true
+// if the child is out-of-flow, e.g. floating or abs-pos.
+TEST_F(NGSpaceUtilsTest, NewFormattingContextForOutOfFlowChild) {

[ikilpatrick, 2017/03/23 16:39:59]

thanks for this :)

[Gleb Lanbin, 2017/03/24 20:10:05]

Acknowledged.

+  auto run_test = [&](const ComputedStyle& style) {
+    RefPtr<NGConstraintSpace> not_used_space =
+        space_builder_.ToConstraintSpace(NGWritingMode::kHorizontalTopBottom);
+    EXPECT_TRUE(IsNewFormattingContextForInFlowBlockLevelChild(
+        *not_used_space.get(), style));
+  };
+  RefPtr<ComputedStyle> style = ComputedStyle::create();
+  style->setFloating(EFloat::kLeft);
+  run_test(*style.get());
+
+  style = ComputedStyle::create();
+  style->setPosition(EPosition::kAbsolute);
+  run_test(*style.get());
+
+  style = ComputedStyle::create();
+  style->setPosition(EPosition::kFixed);
+  run_test(*style.get());
+}
+
+}  // namespace
+}  // namespace blink