third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc - Issue 2770483002: CS of out-of-flow positioned objects should have is_new_fc == true

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

Issue 2770483002: CS of out-of-flow positioned objects should have is_new_fc == true (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/BUILD.gn ('k') | third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc » ('j') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

diff --git a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

index 76cff68486a5f9dcf43829dfa63fd3b19d3bd243..c2e236ba3069ce5d3562e3706174dc25852379e4 100644

--- a/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

+++ b/third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm.cc

@@ -526,6 +526,8 @@ RefPtr<NGConstraintSpace> NGBlockLayoutAlgorithm::CreateConstraintSpaceForChild(

if (is_new_bfc) {

DCHECK(builder_.BfcOffset());

space_available -= curr_bfc_offset_.block_offset;

+ // TODO(glebl): Check correctness of the statement below.

+ space_builder_.SetBfcOffset(NGLogicalOffset());

}

space_builder_.SetFragmentainerSpaceAvailable(space_available);