third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h - Issue 2770483002: CS of out-of-flow positioned objects should have is_new_fc == true

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h

Issue 2770483002: CS of out-of-flow positioned objects should have is_new_fc == true (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc ('k') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc » ('j') | third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 // Copyright 2016 The Chromium Authors. All rights reserved.	1 // Copyright 2016 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef NGConstraintSpaceBuilder_h	5 #ifndef NGConstraintSpaceBuilder_h

6 #define NGConstraintSpaceBuilder_h	6 #define NGConstraintSpaceBuilder_h

7	7

8 #include "core/layout/ng/ng_constraint_space.h"	8 #include "core/layout/ng/ng_constraint_space.h"

9 #include "wtf/Allocator.h"	9 #include "wtf/Allocator.h"

10 #include "wtf/Optional.h"	10 #include "wtf/Optional.h"

(...skipping 62 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
73 LayoutUnit fragmentainer_space_available_;	73 LayoutUnit fragmentainer_space_available_;

74	74

75 unsigned parent_writing_mode_ : 3;	75 unsigned parent_writing_mode_ : 3;

76 unsigned is_fixed_size_inline_ : 1;	76 unsigned is_fixed_size_inline_ : 1;

77 unsigned is_fixed_size_block_ : 1;	77 unsigned is_fixed_size_block_ : 1;

78 unsigned is_shrink_to_fit_ : 1;	78 unsigned is_shrink_to_fit_ : 1;

79 unsigned is_inline_direction_triggers_scrollbar_ : 1;	79 unsigned is_inline_direction_triggers_scrollbar_ : 1;

80 unsigned is_block_direction_triggers_scrollbar_ : 1;	80 unsigned is_block_direction_triggers_scrollbar_ : 1;

81 unsigned fragmentation_type_ : 2;	81 unsigned fragmentation_type_ : 2;

82 unsigned is_new_fc_ : 1;	82 unsigned is_new_fc_ : 1;

	83 // Whether the parent constraint space establishes a new formatting context.

	84 unsigned is_parent_new_fc_ : 1;

83 unsigned is_anonymous_ : 1;	85 unsigned is_anonymous_ : 1;

84 unsigned text_direction_ : 1;	86 unsigned text_direction_ : 1;

85	87

86 NGMarginStrut margin_strut_;	88 NGMarginStrut margin_strut_;

87 NGLogicalOffset bfc_offset_;	89 NGLogicalOffset bfc_offset_;

88 std::shared_ptr<NGExclusions> exclusions_;	90 std::shared_ptr<NGExclusions> exclusions_;

89 WTF::Optional<LayoutUnit> clearance_offset_;	91 WTF::Optional<LayoutUnit> clearance_offset_;

90 };	92 };

91	93

92 } // namespace blink	94 } // namespace blink

93	95

94 #endif // NGConstraintSpaceBuilder	96 #endif // NGConstraintSpaceBuilder

OLD	NEW