Do not show permission bubble when browser is not active

chrome/browser/permissions/permission_request_manager.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/permissions/permission_request_manager.h"
 
 #include <algorithm>
 
 #include "base/command_line.h"
 #include "base/feature_list.h"
 #include "base/metrics/user_metrics_action.h"
 #include "build/build_config.h"
 #include "chrome/browser/permissions/permission_request.h"
 #include "chrome/browser/permissions/permission_uma_util.h"
+#include "chrome/browser/ui/browser_finder.h"
+#include "chrome/browser/ui/browser_list.h"
 #include "chrome/browser/ui/permission_bubble/permission_prompt.h"
 #include "chrome/common/chrome_features.h"
 #include "chrome/common/chrome_switches.h"
 #include "content/public/browser/browser_thread.h"
 #include "content/public/browser/navigation_handle.h"
 #include "content/public/browser/user_metrics.h"
 #include "url/origin.h"
 
 namespace {
 
@@ skipping 47 matching lines @@
 
 // PermissionRequestManager ----------------------------------------------------
 
 DEFINE_WEB_CONTENTS_USER_DATA_KEY(PermissionRequestManager);
 
 PermissionRequestManager::PermissionRequestManager(
     content::WebContents* web_contents)
     : content::WebContentsObserver(web_contents),
       view_factory_(base::Bind(&PermissionPrompt::Create)),
       view_(nullptr),
+      browser_active_(false),

[sky, 2017/03/27 22:43:45]

Why do you need to cache browser_active_ ? Can't TriggerShowBubble check active?

[Qiang(Joe) Xu, 2017/04/06 22:22:51]

Yes, we can eliminate the usage of browser_active_. I was thinking that they
need to be balanced.

       main_frame_has_fully_loaded_(false),
       persist_(true),
       auto_response_for_test_(NONE),
-      weak_factory_(this) {}
+      weak_factory_(this) {
+  BrowserList::AddObserver(this);
+}
 
 PermissionRequestManager::~PermissionRequestManager() {
+  BrowserList::RemoveObserver(this);
   if (view_ != NULL)
     view_->SetDelegate(NULL);
 
   for (PermissionRequest* request : requests_)
     request->RequestFinished();
   for (PermissionRequest* request : queued_requests_)
     request->RequestFinished();
   for (PermissionRequest* request : queued_frame_requests_)
     request->RequestFinished();
   for (const auto& entry : duplicate_requests_)
@@ skipping 251 matching lines @@
 void PermissionRequestManager::Closing() {
   std::vector<PermissionRequest*>::iterator requests_iter;
   for (requests_iter = requests_.begin();
        requests_iter != requests_.end();
        requests_iter++) {
     CancelledIncludingDuplicates(*requests_iter);
   }
   FinalizeBubble();
 }
 
+void PermissionRequestManager::OnBrowserSetLastActive(Browser* browser) {
+  Browser* found = chrome::FindBrowserWithWebContents(web_contents());
+  if (found != browser)
+    return;
+
+  browser_active_ = true;
+  ScheduleShowBubble();
+}
+
+void PermissionRequestManager::OnBrowserNoLongerActive(Browser* browser) {
+  Browser* found = chrome::FindBrowserWithWebContents(web_contents());
+  if (found != browser)
+    return;
+
+  browser_active_ = false;
+}
+
 void PermissionRequestManager::ScheduleShowBubble() {
   // ::ScheduleShowBubble() will be called again when the main frame will be
   // loaded.
   if (!main_frame_has_fully_loaded_)
     return;
 
   content::BrowserThread::PostTask(
       content::BrowserThread::UI,
       FROM_HERE,
       base::Bind(&PermissionRequestManager::TriggerShowBubble,
                  weak_factory_.GetWeakPtr()));
 }
 
 void PermissionRequestManager::TriggerShowBubble() {
   if (!view_)
     return;
+  if (!browser_active_)
+    return;
   if (IsBubbleVisible())
     return;
   if (!main_frame_has_fully_loaded_)
     return;
   if (requests_.empty() && queued_requests_.empty() &&
       queued_frame_requests_.empty()) {
     return;
   }
 
   if (requests_.empty()) {
@@ skipping 136 matching lines @@
     case DENY_ALL:
       Deny();
       break;
     case DISMISS:
       Closing();
       break;
     case NONE:
       NOTREACHED();
   }
 }