Do not show permission bubble when browser is not active

chrome/browser/ui/views/frame/browser_view.cc

 // Copyright 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_view.h"
 
 #include <stdint.h>
 
 #include <algorithm>
 #include <memory>
@@ skipping 1803 matching lines @@
   // BrowserView. By destroying here we ensure all said classes are valid.
   std::vector<content::WebContents*> contents;
   while (browser()->tab_strip_model()->count())
     contents.push_back(browser()->tab_strip_model()->DetachWebContentsAt(0));
   // Note: The BrowserViewTest tests rely on the contents being destroyed in the
   // order that they were present in the tab strip.
   for (auto* content : contents)
     delete content;
 }
 
+void BrowserView::OnWidgetVisibilityChanged(views::Widget* widget,

[sky, 2017/03/27 15:47:51]

I think this logic belongs closer to the permissions code rather than
BrowserView. I think the permissions should be the one determining if the
browser containing the webcontents is the active browser, and it not install a
BrowserListObserver. Once the browser is active *and* the webcontents is active
then show the bubble.

[Qiang(Joe) Xu, 2017/03/27 21:09:52]

Yeah, I agree. And checking activation instead of visibility seems more
reasonable. It also covers more cases, like a permission bubble is scheduled but
another browser is created and set as active. 

+                                            bool visible) {
+  DCHECK_EQ(GetWidget(), widget);
+  if (widget->IsClosed() || !GetActiveWebContents())
+    return;
+
+  PermissionRequestManager::FromWebContents(GetActiveWebContents())
+      ->OnBrowserVisibilityChanged(visible);
+}
+
 void BrowserView::OnWidgetActivationChanged(views::Widget* widget,
                                             bool active) {
   if (active)
     BrowserList::SetLastActive(browser_.get());
   else
     BrowserList::NotifyBrowserNoLongerActive(browser_.get());
 
   if (!extension_keybinding_registry_ &&
       GetFocusManager()) {  // focus manager can be null in tests.
     extension_keybinding_registry_.reset(new ExtensionKeybindingRegistryViews(
@@ skipping 842 matching lines @@
 }
 
 extensions::ActiveTabPermissionGranter*
 BrowserView::GetActiveTabPermissionGranter() {
   content::WebContents* web_contents = GetActiveWebContents();
   if (!web_contents)
     return nullptr;
   return extensions::TabHelper::FromWebContents(web_contents)
       ->active_tab_permission_granter();
 }