Add SpellCheckMarkerList in preparation for DocumentMarkerController refactor

third_party/WebKit/Source/core/editing/markers/SpellCheckMarkerList.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SpellCheckMarkerList_h
+#define SpellCheckMarkerList_h
+
+#include "core/editing/markers/EditingMarkerList.h"
+
+namespace blink {
+
+class Text;
+
+class CORE_EXPORT SpellCheckMarkerList : public EditingMarkerList {

[yosin_UTC9, 2017/03/27 05:02:50]

nit: Please mark this class |final|

+ public:
+  explicit SpellCheckMarkerList(DocumentMarker::MarkerType);
+
+  // DocumentMarkerList implementations
+  DocumentMarker::MarkerType allowedMarkerType() const final;

[yosin_UTC9, 2017/03/27 05:02:51]

nit: interface implementations should be in |private| section.

[rlanday, 2017/03/27 21:59:24]

Sorry, I don't understand what you mean here; these methods are all public in
DocumentMarkerList and won't be callable on SpellCheckMarkerList if I make them
private here. E.g. SpellCheckMarkerList will get a compilation error trying to
call add().

[Xiaocheng, 2017/03/27 22:08:24]

In most cases, subclasses put overridden functions in their private sections,
even though the superclass declares the function as public.

Just like what you did for SetCharacterDataCommand, where SCDC::doApply and
SCDC::doUnapply are private, though they override public EditCommand::doApply
and EditCommand::doUnapply.

+  bool isSpellCheckMarkerList() const final;
+  void push_back(DocumentMarker*) final;
+
+  // SpellCheckMarkerList-specific
+  void removeMarkersForWords(const Text& textNode, const Vector<String>& words);
+
+ private:
+  DocumentMarker::MarkerType m_type;

[yosin_UTC9, 2017/03/27 05:02:51]

nit: s/DocumentMarker::MarkerType/const DocumentMarker::MarkerType/

+
+  DISALLOW_COPY_AND_ASSIGN(SpellCheckMarkerList);
+};
+
+DEFINE_TYPE_CASTS(SpellCheckMarkerList,
+                  DocumentMarkerList,
+                  list,
+                  list->isSpellCheckMarkerList(),
+                  list.isSpellCheckMarkerList());
+
+}  // namespace blink
+
+#endif  // SpellCheckMarkerList_h