Issue 27704002: Make it possible to run a test only in the standard variant.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 27704002: Make it possible to run a test only in the standard variant. (Closed)

Created:
7 years, 2 months ago by Sven Panne

Modified:
7 years, 2 months ago

Reviewers:
Jakob Kummerow

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Make it possible to run a test only in the standard variant. Use this for mjsunit/unicode-case-overoptimization, which is not related to Crankshaft at all and takes ages. R=jkummerow@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17255

Patch Set 1 #

Total comments: 3

Patch Set 2 : Incorporated feedback #

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+16 lines, -8 lines)			Patch
M	test/benchmarks/testcfg.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	test/mjsunit/mjsunit.status	View	1	1 chunk	+1 line, -1 line	0 comments	Download
M	test/preparser/testcfg.py	View		1 chunk	+1 line, -1 line	0 comments	Download
M	tools/run-tests.py	View	1	1 chunk	+3 lines, -2 lines	0 comments	Download
M	tools/testrunner/local/statusfile.py	View	1	3 chunks	+6 lines, -1 line	0 comments	Download
M	tools/testrunner/local/testsuite.py	View		1 chunk	+4 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Jakob Kummerow

LGTM with nits. https://codereview.chromium.org/27704002/diff/1/tools/run-tests.py File tools/run-tests.py (right): https://codereview.chromium.org/27704002/diff/1/tools/run-tests.py#newcode335 tools/run-tests.py:335: s.tests = [ t.CopyAddingFlags(v) for t ...

7 years, 2 months ago (2013-10-17 13:03:41 UTC) #2

Sven Panne

7 years, 2 months ago (2013-10-17 13:09:37 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r17255 (presubmit successful).

Expand Messages | Collapse Messages