Add setup action interface

content/public/android/javatests/src/org/chromium/content/browser/JavaBridgeActivityTestRule.java

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 package org.chromium.content.browser;
 
 import org.junit.runner.Description;
 import org.junit.runners.model.Statement;
 
+import org.chromium.base.test.SetUpTestRule;
 import org.chromium.content.browser.test.util.TestCallbackHelperContainer;
 import org.chromium.content_shell_apk.ContentShellActivity;
 import org.chromium.content_shell_apk.ContentShellActivityTestRule;
 import org.chromium.content_shell_apk.ContentShellTestCommon.TestCommonCallback;
 
 import java.lang.annotation.Annotation;
 
 /**
  * ActivityTestRule with common functionality for testing the Java Bridge.
  */
 public class JavaBridgeActivityTestRule
-        extends ContentShellActivityTestRule implements TestCommonCallback<ContentShellActivity> {
-    private JavaBridgeTestCommon mTestCommon;
-
-    public JavaBridgeActivityTestRule() {
-        super();
-        mTestCommon = new JavaBridgeTestCommon(this);
-    }
+        extends ContentShellActivityTestRule implements TestCommonCallback<ContentShellActivity>,
+                                                        SetUpTestRule<JavaBridgeActivityTestRule> {
+    private JavaBridgeTestCommon mTestCommon = new JavaBridgeTestCommon(this);
+    private boolean mRunSetUp = false;
 
     /**
      * Sets up the ContentView. Intended to be called from setUp().
      */
     private void setUpContentView() {
         mTestCommon.setUpContentView();
     }
 
     public TestCallbackHelperContainer getTestCallBackHelperContainer() {
         return mTestCommon.getTestCallBackHelperContainer();
@@ skipping 17 matching lines @@
             final Class<? extends Annotation> requiredAnnotation) throws Exception {
         mTestCommon.injectObjectsAndReload(object1, name1, object2, name2, requiredAnnotation);
     }
 
     public void synchronousPageReload() throws Throwable {
         mTestCommon.synchronousPageReload();
     }
 
     @Override
     public Statement apply(final Statement base, Description desc) {
-        return super.apply(new Statement() {
-            @Override
-            public void evaluate() throws Throwable {
-                setUpContentView();
-                base.evaluate();
-            }
-        }, desc);
+        return super.apply(new SetUpTestRule.SetUpStatement(base, this, mRunSetUp), desc);
+    }
+
+    @Override
+    public JavaBridgeActivityTestRule shouldSetUp(boolean shouldSetUp) {

[jbudorick, 2017/03/28 01:13:28]

So every rule supporting this behavior would need to do something like this, w/
its own boolean & shouldSetUp implementation?

[the real yoland, 2017/03/28 01:32:50]

ya, one way to decrease the boilerplate code is to create an abstract class that
implements these methods.

[jbudorick, 2017/03/28 01:36:59]

Let's talk about this offline.

+        mRunSetUp = shouldSetUp;
+        return this;
+    }
+
+    @Override
+    public void setUp() {
+        setUpContentView();
     }
 }