WebVR: add angular velocity estimate to pose

chrome/browser/android/vr_shell/vr_shell.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_ANDROID_VR_SHELL_VR_SHELL_H_
 #define CHROME_BROWSER_ANDROID_VR_SHELL_VR_SHELL_H_
 
 #include <jni.h>
 
 #include <memory>
@@ skipping 165 matching lines @@
   void ForceExitVr();
 
   void ProcessUIGesture(std::unique_ptr<blink::WebInputEvent> event);
   void ProcessContentGesture(std::unique_ptr<blink::WebInputEvent> event);
 
   // device::GvrGamepadDataProvider implementation.
   void UpdateGamepadData(device::GvrGamepadData) override;
   void RegisterGamepadDataFetcher(device::GvrGamepadDataFetcher*) override;
 
   // TODO(mthiesse): Find a better place for these functions to live.
-  static device::mojom::VRPosePtr VRPosePtrFromGvrPose(gvr::Mat4f head_mat);
+  static device::mojom::VRPosePtr VRPosePtrFromGvrPose(gvr::Mat4f head_mat,

[cjgrant, 2017/03/24 21:15:40]

Could you:
- Document the function and what each matrix is
- s/mat/matrix/ as per the style guide preference to not abbreviate

[klausw, 2017/03/24 22:13:29]

Done, but only using "matrix" in the header for documentation purposes. For the
.cc file I'd prefer to stick with the pre-existing "mat", especially since
writing out matrix would make some lines excessively long.

+                                                       gvr::Mat4f head_mat_2,
+                                                       int64_t epsilon_nanos);
   static gvr::Sizei GetRecommendedWebVrSize(gvr::GvrApi* gvr_api);
   static device::mojom::VRDisplayInfoPtr CreateVRDisplayInfo(
       gvr::GvrApi* gvr_api,
       gvr::Sizei recommended_size,
       uint32_t device_id);
 
  private:
   ~VrShell() override;
   void PostToGlThreadWhenReady(const base::Closure& task);
   void SetContentPaused(bool paused);
@@ skipping 67 matching lines @@
   base::WeakPtrFactory<VrShell> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(VrShell);
 };
 
 bool RegisterVrShell(JNIEnv* env);
 
 }  // namespace vr_shell
 
 #endif  // CHROME_BROWSER_ANDROID_VR_SHELL_VR_SHELL_H_