Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(185)

Issue 277033002: [Sync] Make BookmarkChangeProcessor resilient against updates before add (Closed)

Created:
6 years, 7 months ago by Nicolas Zea
Modified:
6 years, 7 months ago
Reviewers:
rlarocque
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

[Sync] Make BookmarkChangeProcessor resilient against updates before add Other bookmarks observer might make their own changes on add, triggering updates before the add call arrives. Be resilient against this. BUG=369728 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269645

Patch Set 1 #

Patch Set 2 : Fix test #

Patch Set 3 : CreateOrUpdate #

Unified diffs Side-by-side diffs Delta from patch set Stats (+99 lines, -89 lines) Patch
M chrome/browser/sync/glue/bookmark_change_processor.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/bookmark_change_processor.cc View 1 2 3 chunks +55 lines, -87 lines 0 comments Download
M chrome/browser/sync/profile_sync_service_bookmark_unittest.cc View 1 2 3 chunks +34 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Nicolas Zea
PTAL
6 years, 7 months ago (2014-05-09 20:08:41 UTC) #1
rlarocque
On 2014/05/09 20:08:41, Nicolas Zea wrote: > PTAL Should there be a CreateOrUpdateSyncNode() function? It ...
6 years, 7 months ago (2014-05-09 20:18:18 UTC) #2
Nicolas Zea
On 2014/05/09 20:18:18, rlarocque wrote: > On 2014/05/09 20:08:41, Nicolas Zea wrote: > > PTAL ...
6 years, 7 months ago (2014-05-09 20:28:25 UTC) #3
rlarocque
lgtm
6 years, 7 months ago (2014-05-09 20:32:21 UTC) #4
Nicolas Zea
The CQ bit was checked by zea@chromium.org
6 years, 7 months ago (2014-05-09 20:33:36 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/zea@chromium.org/277033002/60001
6 years, 7 months ago (2014-05-09 20:37:27 UTC) #6
commit-bot: I haz the power
6 years, 7 months ago (2014-05-11 00:14:37 UTC) #7
Message was sent while issue was closed.
Change committed as 269645

Powered by Google App Engine
This is Rietveld 408576698