Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(943)

Unified Diff: media/filters/video_renderer_algorithm.h

Issue 2770253004: Log out-of-order frames in chrome://media-internals. (Closed)
Patch Set: Include timestamps in the log. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/filters/video_renderer_algorithm.h
diff --git a/media/filters/video_renderer_algorithm.h b/media/filters/video_renderer_algorithm.h
index 70e29924d2b01db17b86a24ca77bf6e5cc8630d1..0ce78092a3bede603e8c74399e9cb4f79923c191 100644
--- a/media/filters/video_renderer_algorithm.h
+++ b/media/filters/video_renderer_algorithm.h
@@ -22,6 +22,8 @@
namespace media {
+class MediaLog;
+
// VideoRendererAlgorithm manages a queue of VideoFrames from which it chooses
// frames with the goal of providing a smooth playback experience. I.e., the
// selection process results in the best possible uniformity for displayed frame
@@ -48,8 +50,8 @@ namespace media {
// Combined these three approaches enforce optimal smoothness in many cases.
class MEDIA_EXPORT VideoRendererAlgorithm {
public:
- explicit VideoRendererAlgorithm(
- const TimeSource::WallClockTimeCB& wall_clock_time_cb);
+ VideoRendererAlgorithm(const TimeSource::WallClockTimeCB& wall_clock_time_cb,
+ scoped_refptr<MediaLog> media_log);
~VideoRendererAlgorithm();
// Chooses the best frame for the interval [deadline_min, deadline_max] based
@@ -265,6 +267,9 @@ class MEDIA_EXPORT VideoRendererAlgorithm {
// UpdateEffectiveFramesQueued().
size_t CountEffectiveFramesQueued() const;
+ scoped_refptr<MediaLog> media_log_;
+ int out_of_order_frame_logs_ = 0;
+
// Queue of incoming frames waiting for rendering.
using VideoFrameQueue = std::deque<ReadyFrame>;
VideoFrameQueue frame_queue_;

Powered by Google App Engine
This is Rietveld 408576698