build/config/win/visual_studio_version.gni - Issue 2770193005: build with MSVS will only need VS console environment set up

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: build/config/win/visual_studio_version.gni

Issue 2770193005: build with MSVS will only need VS console environment set up

Patch Set: build with MSVS will need VS console environment set up Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: build/config/win/visual_studio_version.gni

diff --git a/build/config/win/visual_studio_version.gni b/build/config/win/visual_studio_version.gni

index 982fbe8d3f0d0294e28e206638cfa3ee3a902745..11eed00e997e7d1410c93fa45ca0ceca83b8aa2d 100644

--- a/build/config/win/visual_studio_version.gni

+++ b/build/config/win/visual_studio_version.gni

@@ -23,6 +23,10 @@ declare_args() {

}

if (visual_studio_path == "") {

+ test1 = getenv("VSINSTALLDIR") != ""

+ assert(test1, "Please run from within a VS console (with ENV variables)")

+ test2 = getenv("VisualStudioVersion") != ""

+ assert(test1, "Please run from within a VS console (with ENV variables)")

toolchain_data =

exec_script("../../vs_toolchain.py", [ "get_toolchain_dir" ], "scope")

visual_studio_path = toolchain_data.vs_path

« no previous file with comments | « AUTHORS ('k') | build/vs_toolchain.py » ('j') | build/vs_toolchain.py » ('J')