Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(631)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2770193003: Implement request id in PaymentDetailsInit (Closed)
Patch Set: Add comment in mojom Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
index e5df52bce72cbe7f9de0d1fb5c9008ec4fe59463..f42155abcef15a99fb905e8497531ab470402871 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
@@ -14,8 +14,10 @@ namespace blink {
PaymentResponse::PaymentResponse(
payments::mojom::blink::PaymentResponsePtr response,
- PaymentCompleter* paymentCompleter)
- : m_methodName(response->method_name),
+ PaymentCompleter* paymentCompleter,
+ const String& requestId)
+ : m_requestId(requestId),
+ m_methodName(response->method_name),
m_stringifiedDetails(response->stringified_details),
m_shippingAddress(
response->shipping_address
@@ -33,6 +35,7 @@ PaymentResponse::~PaymentResponse() {}
ScriptValue PaymentResponse::toJSONForBinding(ScriptState* scriptState) const {
V8ObjectBuilder result(scriptState);
+ result.addString("requestId", requestId());
result.addString("methodName", methodName());
result.add("details", details(scriptState, ASSERT_NO_EXCEPTION));

Powered by Google App Engine
This is Rietveld 408576698