chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java - Issue 2770193003: Implement request id in PaymentDetailsInit

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

Issue 2770193003: Implement request id in PaymentDetailsInit (Closed)

Patch Set: Add comment in mojom Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentInstrument.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/payments/ServiceWorkerPaymentInstrument.java » ('j') | chrome/test/data/payments/payment_request_id.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

index ca53cbcf63dd9f831990019556b106b7a20b6b33..2b54c682ff1490cd8609e8918c02f0e164ac434b 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/payments/PaymentRequestImpl.java

@@ -295,6 +295,7 @@ public class PaymentRequestImpl

private SectionInformation mUiShippingOptions;

+ private String mId;

private Map<String, PaymentMethodData> mMethodData;

private boolean mRequestShipping;

private boolean mRequestPayerName;

@@ -420,6 +421,8 @@ public class PaymentRequestImpl

if (!parseAndValidateDetailsOrDisconnectFromClient(details)) return;

+ mId = details.id;

PaymentAppFactory.getInstance().create(mWebContents,

Collections.unmodifiableSet(mMethodData.keySet()), this /* callback */);

@@ -1185,7 +1188,7 @@ public class PaymentRequestImpl

}

- instrument.invokePaymentApp(mMerchantName, mSchemelessOriginForPaymentApp,

+ instrument.invokePaymentApp(mId, mMerchantName, mSchemelessOriginForPaymentApp,

mSchemelessIFrameOriginForPaymentApp, mCertificateChain,

Collections.unmodifiableMap(methodData), mRawTotal, mRawLineItems,

Collections.unmodifiableMap(modifiers), this);