Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Unified Diff: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp

Issue 2770193003: Implement request id in PaymentDetailsInit (Closed)
Patch Set: s/requestId/id Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
diff --git a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
index e5df52bce72cbe7f9de0d1fb5c9008ec4fe59463..0b4cb8e13eca0fc66c5461c39e0cf69ade6a3b43 100644
--- a/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
+++ b/third_party/WebKit/Source/modules/payments/PaymentResponse.cpp
@@ -15,7 +15,8 @@ namespace blink {
PaymentResponse::PaymentResponse(
payments::mojom::blink::PaymentResponsePtr response,
PaymentCompleter* paymentCompleter)
- : m_methodName(response->method_name),
+ : m_requestId(response->requestId),
please use gerrit instead 2017/03/27 16:22:36 Use the "id" from the PaymentRequest in the render
rwlbuis 2017/03/27 20:45:29 Done.
+ m_methodName(response->method_name),
m_stringifiedDetails(response->stringified_details),
m_shippingAddress(
response->shipping_address
@@ -33,6 +34,7 @@ PaymentResponse::~PaymentResponse() {}
ScriptValue PaymentResponse::toJSONForBinding(ScriptState* scriptState) const {
V8ObjectBuilder result(scriptState);
+ result.addString("requestId", requestId());
result.addString("methodName", methodName());
result.add("details", details(scriptState, ASSERT_NO_EXCEPTION));

Powered by Google App Engine
This is Rietveld 408576698