Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(488)

Unified Diff: components/payments/content/payment_request.mojom

Issue 2770193003: Implement request id in PaymentDetailsInit (Closed)
Patch Set: s/requestId/id Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/payments/content/payment_request.mojom
diff --git a/components/payments/content/payment_request.mojom b/components/payments/content/payment_request.mojom
index a40f3da2b34b910ed3d4a9899d04a50529a62503..f130861e07f56c3d8c67f41cbfcb88bc6437c6b1 100644
--- a/components/payments/content/payment_request.mojom
+++ b/components/payments/content/payment_request.mojom
@@ -64,6 +64,7 @@ struct PaymentResponse {
// {"nameOnCard": "Jon Doe", "pan": "4111 1111 1111 1111"}
string stringified_details;
+ string requestId;
please use gerrit instead 2017/03/27 16:22:36 The string is never modified inside of the browser
rwlbuis 2017/03/27 20:45:29 Done.
PaymentAddress? shipping_address;
string? shipping_option;
string? payer_name;
@@ -188,6 +189,7 @@ struct PaymentDetails {
array<PaymentShippingOption> shipping_options;
array<PaymentDetailsModifier> modifiers;
string error = "";
+ string? id;
please use gerrit instead 2017/03/27 16:22:36 Add a comment about where this string comes from a
rwlbuis 2017/03/27 20:45:29 Done.
};
enum PaymentShippingType {

Powered by Google App Engine
This is Rietveld 408576698