components/subresource_filter/core/browser/subresource_filter_features.h - Issue 2770153004: Unittests for the Safe Browsing Subresource filter navigation throttle

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/subresource_filter/core/browser/subresource_filter_features.h

Issue 2770153004: Unittests for the Safe Browsing Subresource filter navigation throttle (Closed)

Patch Set: comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc ('K') | « components/subresource_filter/content/browser/subresource_filter_safe_browsing_activation_throttle_unittest.cc ('k') | components/subresource_filter/core/browser/subresource_filter_features.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/subresource_filter/core/browser/subresource_filter_features.h

diff --git a/components/subresource_filter/core/browser/subresource_filter_features.h b/components/subresource_filter/core/browser/subresource_filter_features.h

index 529580f4554d169d8ea518e63c802904fb4e6ccb..19f9c00b922c2176d6ca127292fa25ef19d100d1 100644

--- a/components/subresource_filter/core/browser/subresource_filter_features.h

+++ b/components/subresource_filter/core/browser/subresource_filter_features.h

@@ -18,9 +18,6 @@ extern const base::Feature kSafeBrowsingSubresourceFilter;

// Enables the new experimental UI for the Subresource Filter.

extern const base::Feature kSafeBrowsingSubresourceFilterExperimentalUI;

-// Guards creation of the SubresourceFilterSafeBrowsingActivationThrottle

-extern const base::Feature kSubresourceFilterSafeBrowsingActivationThrottle;

engedy 2017/04/06 13:50:38 ... and also mention that this CL removes the feat

melandory 2017/04/07 09:09:44 Done.

// Name/values of the variation parameter controlling maximum activation level.

extern const char kActivationLevelParameterName[];

extern const char kActivationLevelDryRun[];