Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(182)

Issue 2770143002: More generic function type cases working (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 9 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -19 lines) Patch
M pkg/analyzer/lib/error/error.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/builder.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/analyzer/lib/src/dart/element/element.dart View 2 chunks +6 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/declaration_resolver.dart View 5 chunks +46 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/summary/summarize_ast.dart View 1 chunk +4 lines, -2 lines 0 comments Download
M pkg/analyzer/test/generated/declaration_resolver_test.dart View 1 chunk +30 lines, -0 lines 0 comments Download
M tests/language/language_analyzer2.status View 2 chunks +0 lines, -7 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
3 years, 9 months ago (2017-03-23 21:53:37 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-23 23:36:33 UTC) #3
Brian Wilkerson
3 years, 9 months ago (2017-03-24 15:08:28 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ccf768144feb6027117576dac3bb2ca09b9cad64 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698