third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

index 5fcadc5dc10003e774c206c595416f4854b8c3fa..4408a335a6f2e03b18b0b02ade5cfd6e8bc9b2b4 100644

--- a/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutObjectTest.cpp

@@ -21,9 +21,9 @@ class LayoutObjectTest : public RenderingTest {

TEST_F(LayoutObjectTest, LayoutDecoratedNameCalledWithPositionedObject) {

setBodyInnerHTML("<div id='div' style='position: fixed'>test</div>");

Element* div = document().getElementById(AtomicString("div"));

- ASSERT(div);

+ DCHECK(div);

LayoutObject* obj = div->layoutObject();

- ASSERT(obj);

+ DCHECK(obj);

EXPECT_STREQ("LayoutBlockFlow (positioned)",

obj->decoratedName().ascii().data());

}