third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp - Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)

Patch Set: Split some DCHECKs and add DCHECK_ops wherever possible Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutCounter.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutEmbeddedObject.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

diff --git a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

index 697ce090f68bdc40dcdf379503a3fc5a9ad0dab5..d66b91f933db947fe44e09c52c5792c06b4130a5 100644

--- a/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

+++ b/third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp

@@ -179,7 +179,7 @@ static int getHeightForLineCount(const LayoutBlockFlow* blockFlow,

}

static RootInlineBox* lineAtIndex(const LayoutBlockFlow* blockFlow, int i) {

- ASSERT(i >= 0);

+ DCHECK_GE(i, 0);

if (blockFlow->style()->visibility() != EVisibility::kVisible)

return nullptr;

@@ -264,7 +264,7 @@ static void clearTruncation(LayoutBlockFlow* blockFlow) {

LayoutDeprecatedFlexibleBox::LayoutDeprecatedFlexibleBox(Element& element)

: LayoutBlock(&element) {

- ASSERT(!childrenInline());

+ DCHECK(!childrenInline());

m_stretchingChildren = false;

if (!isAnonymous()) {

const KURL& url = document().url();

@@ -359,7 +359,7 @@ void LayoutDeprecatedFlexibleBox::computeIntrinsicLogicalWidths(

}

void LayoutDeprecatedFlexibleBox::layoutBlock(bool relayoutChildren) {

- ASSERT(needsLayout());

+ DCHECK(needsLayout());

if (!relayoutChildren && simplifiedLayout())

return;