Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableCol.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Check if DCHECK is ON in TextAutosizer Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp b/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
index eefe5b6744edb2e965247c43d5b72960cda1510b..7fb4e17b0ade65a2eaa27ee1fd5510465a929a96 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableCol.cpp
@@ -121,7 +121,7 @@ LayoutRect LayoutTableCol::localVisualRect() const {
// The correctness of this method depends on the fact that LayoutTableCol's
// location is always zero.
- ASSERT(this->location() == LayoutPoint());
+ DCHECK(this->location() == LayoutPoint());
tkent 2017/04/04 01:36:17 Use DCHECK_EQ if it doesn't cause a compile failur
mrunal 2017/04/05 00:39:14 Not possible because of compile failure.
return table->localVisualRect();
}
@@ -145,8 +145,8 @@ LayoutTableCol* LayoutTableCol::enclosingColumnGroup() const {
return nullptr;
LayoutTableCol* parentColumnGroup = toLayoutTableCol(parent());
- ASSERT(parentColumnGroup->isTableColumnGroup());
- ASSERT(isTableColumn());
+ DCHECK(parentColumnGroup->isTableColumnGroup());
+ DCHECK(isTableColumn());
return parentColumnGroup;
}

Powered by Google App Engine
This is Rietveld 408576698