Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutQuote.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Check if DCHECK is ON in TextAutosizer Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutQuote.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutQuote.cpp b/third_party/WebKit/Source/core/layout/LayoutQuote.cpp
index 3db4be4eb263272f60e2115555e4d56f02dc848b..2aa4e8b7ef9700d80c8753b2923d7da125774987 100644
--- a/third_party/WebKit/Source/core/layout/LayoutQuote.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutQuote.cpp
@@ -43,8 +43,8 @@ LayoutQuote::LayoutQuote(PseudoElement& pseudo, QuoteType quote)
}
LayoutQuote::~LayoutQuote() {
- ASSERT(!m_attached);
- ASSERT(!m_next && !m_previous);
+ DCHECK(!m_attached);
+ DCHECK(!m_next && !m_previous);
tkent 2017/04/04 01:36:17 Split this into two. DCHECK(!m_next); DCHECK(!m_p
mrunal 2017/04/05 00:39:14 Done.
}
void LayoutQuote::willBeDestroyed() {
@@ -309,10 +309,10 @@ const QuotesData* LayoutQuote::quotesData() const {
}
void LayoutQuote::attachQuote() {
- ASSERT(view());
- ASSERT(!m_attached);
- ASSERT(!m_next && !m_previous);
- ASSERT(isRooted());
+ DCHECK(view());
+ DCHECK(!m_attached);
+ DCHECK(!m_next && !m_previous);
tkent 2017/04/04 01:36:17 Split this into two. DCHECK(!m_next); DCHECK(!m_p
mrunal 2017/04/05 00:39:14 Done.
+ DCHECK(isRooted());
if (!view()->layoutQuoteHead()) {
view()->setLayoutQuoteHead(this);
@@ -345,15 +345,15 @@ void LayoutQuote::attachQuote() {
for (LayoutQuote* quote = this; quote; quote = quote->m_next)
quote->updateDepth();
- ASSERT(!m_next || m_next->m_attached);
- ASSERT(!m_next || m_next->m_previous == this);
- ASSERT(!m_previous || m_previous->m_attached);
- ASSERT(!m_previous || m_previous->m_next == this);
+ DCHECK(!m_next || m_next->m_attached);
+ DCHECK(!m_next || m_next->m_previous == this);
+ DCHECK(!m_previous || m_previous->m_attached);
+ DCHECK(!m_previous || m_previous->m_next == this);
}
void LayoutQuote::detachQuote() {
- ASSERT(!m_next || m_next->m_attached);
- ASSERT(!m_previous || m_previous->m_attached);
+ DCHECK(!m_next || m_next->m_attached);
+ DCHECK(!m_previous || m_previous->m_attached);
if (!m_attached)
return;
@@ -378,7 +378,7 @@ void LayoutQuote::detachQuote() {
}
void LayoutQuote::updateDepth() {
- ASSERT(m_attached);
+ DCHECK(m_attached);
int oldDepth = m_depth;
m_depth = 0;
if (m_previous) {

Powered by Google App Engine
This is Rietveld 408576698