Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutListBox.cpp

Issue 2770123003: Replace ASSERT with DCHECK in core/layout/ excluding subdirs (Closed)
Patch Set: Check if DCHECK is ON in TextAutosizer Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutListBox.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutListBox.cpp b/third_party/WebKit/Source/core/layout/LayoutListBox.cpp
index 7388ff3e1b80bd24322a524675e94ae7d806d8b2..3ac15d887eb0567bf7c306907ee095907549963b 100644
--- a/third_party/WebKit/Source/core/layout/LayoutListBox.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutListBox.cpp
@@ -46,9 +46,9 @@ const int defaultSize = 4;
const int defaultPaddingBottom = 1;
LayoutListBox::LayoutListBox(Element* element) : LayoutBlockFlow(element) {
- ASSERT(element);
- ASSERT(element->isHTMLElement());
- ASSERT(isHTMLSelectElement(element));
+ DCHECK(element);
+ DCHECK(element->isHTMLElement());
+ DCHECK(isHTMLSelectElement(element));
}
LayoutListBox::~LayoutListBox() {}
@@ -128,8 +128,8 @@ void LayoutListBox::computeIntrinsicLogicalWidths(
void LayoutListBox::scrollToRect(const LayoutRect& rect) {
if (hasOverflowClip()) {
- ASSERT(layer());
- ASSERT(layer()->getScrollableArea());
+ DCHECK(layer());
+ DCHECK(layer()->getScrollableArea());
layer()->getScrollableArea()->scrollIntoView(
rect, ScrollAlignment::alignToEdgeIfNeeded,
ScrollAlignment::alignToEdgeIfNeeded);

Powered by Google App Engine
This is Rietveld 408576698