Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(303)

Unified Diff: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm

Issue 2770113006: Add no-image image in ContentSuggestions (Closed)
Patch Set: Fix tests Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm
diff --git a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm
index b58e7d305d5ad44e81c4cb6e7d1ceb1685770d7d..37adbfead26c1aaa0ce6b0cdf243d6bae836fab9 100644
--- a/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm
+++ b/ios/chrome/browser/ui/content_suggestions/cells/content_suggestions_article_item_unittest.mm
@@ -34,13 +34,15 @@ TEST(ContentSuggestionsArticleItemTest, CellIsConfiguredWithoutImage) {
ContentSuggestionsArticleCell* cell = [[[item cellClass] alloc] init];
ASSERT_EQ([ContentSuggestionsArticleCell class], [cell class]);
ASSERT_EQ(url, item.articleURL);
- ASSERT_NE(nil, item.image);
+ ASSERT_EQ(nil, item.image);
+ id cellMock = OCMPartialMock(cell);
+ OCMExpect([cellMock setContentImage:item.image]);
// Action.
[item configureCell:cell];
// Tests.
- EXPECT_EQ(item.image, cell.imageView.image);
+ EXPECT_OCMOCK_VERIFY(cellMock);
EXPECT_EQ(title, cell.titleLabel.text);
EXPECT_EQ(subtitle, cell.subtitleLabel.text);
EXPECT_OCMOCK_VERIFY(delegateMock);
@@ -61,6 +63,7 @@ TEST(ContentSuggestionsArticleItemTest, DontFetchImageIsImageIsBeingFetched) {
subtitle:subtitle
delegate:niceDelegateMock
url:url];
+ item.image = [[UIImage alloc] init];
OCMExpect([niceDelegateMock loadImageForArticleItem:item]);
ContentSuggestionsArticleCell* cell = [[[item cellClass] alloc] init];
@@ -71,12 +74,14 @@ TEST(ContentSuggestionsArticleItemTest, DontFetchImageIsImageIsBeingFetched) {
id strictDelegateMock =
OCMStrictProtocolMock(@protocol(ContentSuggestionsArticleItemDelegate));
item.delegate = strictDelegateMock;
+ id cellMock = OCMPartialMock(cell);
+ OCMExpect([cellMock setContentImage:item.image]);
// Action.
[item configureCell:cell];
// Tests.
- EXPECT_EQ(item.image, cell.imageView.image);
+ EXPECT_OCMOCK_VERIFY(cellMock);
EXPECT_EQ(title, cell.titleLabel.text);
EXPECT_EQ(subtitle, cell.subtitleLabel.text);
}

Powered by Google App Engine
This is Rietveld 408576698