Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issue 2770033002: Parse FunctionDeclarationStatement(s) with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Parse FunctionDeclarationStatement(s) with Fasta. R=paulberry@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/9aea262eb475f2898bb28824426227b1048adb17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+102 lines, -76 lines) Patch
M pkg/analyzer/lib/src/fasta/ast_builder.dart View 1 chunk +27 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 6 chunks +68 lines, -76 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
scheglov
3 years, 9 months ago (2017-03-23 15:19:41 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-23 16:18:40 UTC) #2
scheglov
3 years, 9 months ago (2017-03-23 16:29:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
9aea262eb475f2898bb28824426227b1048adb17 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698