Restrict getInstalledRelatedApps() to non-incognito contexts.

content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java

Index: content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java b/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
index 8a4526a9a0023c99a706b9662c0d5bcff0037ffd..4f34d9388899c1c2b614b3dadea1197d12231cc4 100644
--- a/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/framehost/RenderFrameHostImpl.java
@@ -17,17 +17,19 @@ public class RenderFrameHostImpl implements RenderFrameHost {
     private long mNativeRenderFrameHostAndroid;
     // mDelegate can be null.
     final RenderFrameHostDelegate mDelegate;
+    final boolean mIncognito;
 
-    private RenderFrameHostImpl(
-            long nativeRenderFrameHostAndroid, RenderFrameHostDelegate delegate) {
+    private RenderFrameHostImpl(long nativeRenderFrameHostAndroid, RenderFrameHostDelegate delegate,
+            boolean isIncognito) {

[Matt Giuca, 2017/03/24 05:06:55]

Formatting looks weird; is this clang-formatted?

[Timothy Loh, 2017/03/27 02:06:23]

It is.

         mNativeRenderFrameHostAndroid = nativeRenderFrameHostAndroid;
         mDelegate = delegate;
+        mIncognito = isIncognito;
     }
 
     @CalledByNative
-    private static RenderFrameHostImpl create(
-            long nativeRenderFrameHostAndroid, RenderFrameHostDelegate delegate) {
-        return new RenderFrameHostImpl(nativeRenderFrameHostAndroid, delegate);
+    private static RenderFrameHostImpl create(long nativeRenderFrameHostAndroid,
+            RenderFrameHostDelegate delegate, boolean isIncognito) {
+        return new RenderFrameHostImpl(nativeRenderFrameHostAndroid, delegate, isIncognito);
     }
 
     @CalledByNative
@@ -50,5 +52,16 @@ public class RenderFrameHostImpl implements RenderFrameHost {
         return nativeGetLastCommittedURL(mNativeRenderFrameHostAndroid);
     }
 
+    /**
+     * Returns whether we're in incognito mode.
+     *
+     * This function shouldn't really be on here. If we end up needing more

[Matt Giuca, 2017/03/24 05:06:55]

Maybe make this a TODO?

[Timothy Loh, 2017/03/27 02:06:23]

Done.

+     * logic from the native BrowserContext, we should add a wrapper for that
+     * and move this function there.
+     */
+    public boolean isIncognito() {

[Matt Giuca, 2017/03/24 05:06:55]

Add this method to the interface and @Override it.

[Matt Giuca, 2017/03/24 05:31:44]

Never mind... see below.

+        return mIncognito;

[Matt Giuca, 2017/03/24 05:06:55]

Should this be calling through to the native implementation rather than caching
the value here?

(I assume it isn't possible for a RFH to change between incognito/not incognito
dynamically? If so then this is fine.) 

[Matt Giuca, 2017/03/24 05:31:44]

Never mind, I see you had this earlier and was asked to change it.

+    }
+
     private native String nativeGetLastCommittedURL(long nativeRenderFrameHostAndroid);
 }