Restrict getInstalledRelatedApps() to non-incognito contexts.

content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java

Index: content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java b/content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java
index fb4353128202f721f1abfc488d81e1e94a0df9c9..c4bc86af42f7791798b2c97bff0bb950f18adb84 100644
--- a/content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java
+++ b/content/public/android/java/src/org/chromium/content/browser/installedapp/InstalledAppProviderImpl.java
@@ -54,6 +54,11 @@ public class InstalledAppProviderImpl implements InstalledAppProvider {
          * Gets the URL of the current frame. Can return null (if the frame has disappeared).
          */
         public URI getUrl();
+
+        /**
+         * Checks if we're in incognito. If the frame has disappeared this returns true.
+         */
+        public boolean isIncognito();
     }
 
     public InstalledAppProviderImpl(FrameUrlDelegate frameUrlDelegate, Context context) {
@@ -64,6 +69,10 @@ public class InstalledAppProviderImpl implements InstalledAppProvider {
     @Override
     public void filterInstalledApps(
             RelatedApplication[] relatedApps, FilterInstalledAppsResponse callback) {
+        if (mFrameUrlDelegate.isIncognito()) {
+            callback.call(new RelatedApplication[0]);

[boliu, 2017/03/23 18:12:52]

return?

[Timothy Loh, 2017/03/24 03:11:31]

Fixed, thanks. This of course makes the test pass :)

+        }
+
         URI frameUrl = mFrameUrlDelegate.getUrl();
         ArrayList<RelatedApplication> installedApps = new ArrayList<RelatedApplication>();
         PackageManager pm = mContext.getPackageManager();
@@ -79,6 +88,7 @@ public class InstalledAppProviderImpl implements InstalledAppProvider {
                 installedApps.add(app);
             }
         }
+
         RelatedApplication[] installedAppsArray = new RelatedApplication[installedApps.size()];
         installedApps.toArray(installedAppsArray);
         callback.call(installedAppsArray);