Restrict getInstalledRelatedApps() to non-incognito contexts.

content/browser/frame_host/render_frame_host_android.cc

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/frame_host/render_frame_host_android.h"
 
 #include "base/android/jni_string.h"
 #include "base/logging.h"
 #include "content/browser/frame_host/render_frame_host_delegate.h"
 #include "content/browser/frame_host/render_frame_host_impl.h"
+#include "content/public/browser/browser_context.h"
+#include "content/public/browser/site_instance.h"
 #include "jni/RenderFrameHostImpl_jni.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::JavaParamRef;
 using base::android::JavaRef;
 using base::android::ScopedJavaLocalRef;
 
 namespace content {
 
@@ skipping 27 matching lines @@
   return obj_.get(env);
 }
 
 ScopedJavaLocalRef<jstring> RenderFrameHostAndroid::GetLastCommittedURL(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) const {
   return ConvertUTF8ToJavaString(
       env, render_frame_host_->GetLastCommittedURL().spec());
 }
 
+jboolean RenderFrameHostAndroid::IsIncognito(

[boliu, 2017/03/23 18:12:51]

I feel RFH has no business exposing whether it's InCognito or not. this is a
slippery slop of these things becoming "god objects" that's just a bunch of
unrelated code.

How hard is it to have a java counterpart to BrowserContext instead?

[Timothy Loh, 2017/03/24 03:11:31]

For now I added a comment in the header file -- I'm not at all familiar with RFH
or JNI to make an accurate decision on whether we should add a BrowserContext
class now, or at some point in the future when we need other functions (do we
also need a SiteInstance to get to the BrowserContext?)

[boliu, 2017/03/24 03:54:49]

Can skip SiteInstance if there is no need.

This is ok for now since this is not exposed out of content. But someone will
draw the short straw at some point..

+    JNIEnv* env,
+    const JavaParamRef<jobject>& obj) const {
+  return render_frame_host_->GetSiteInstance()
+      ->GetBrowserContext()
+      ->IsOffTheRecord();
+}
+
 }  // namespace content