Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(668)

Issue 276993003: Pass the gold binary directory to the linker with an absolute path (Closed)

Created:
6 years, 7 months ago by cjhopman
Modified:
6 years, 7 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Pass the gold binary directory to the linker with an absolute path The previous way "<(PRODUCT_DIR)/../../" doesn't work very well with some non-default output directories. (This was fixed for linux in https://codereview.chromium.org/83673002) Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270167

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/common.gypi View 1 chunk +1 line, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
cjhopman
https://codereview.chromium.org/276993003/diff/1/build/common.gypi File build/common.gypi (right): https://codereview.chromium.org/276993003/diff/1/build/common.gypi#newcode3524 build/common.gypi:3524: '-B<!(cd <(DEPTH) && pwd -P)/build/android/arm-linux-androideabi-gold', We should be able ...
6 years, 7 months ago (2014-05-10 00:28:05 UTC) #1
Nico
lgtm ಠ_ಠ
6 years, 7 months ago (2014-05-13 08:15:28 UTC) #2
cjhopman
The CQ bit was checked by cjhopman@chromium.org
6 years, 7 months ago (2014-05-13 16:28:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/cjhopman@chromium.org/276993003/1
6 years, 7 months ago (2014-05-13 16:29:41 UTC) #4
commit-bot: I haz the power
6 years, 7 months ago (2014-05-13 19:32:53 UTC) #5
Message was sent while issue was closed.
Change committed as 270167

Powered by Google App Engine
This is Rietveld 408576698