|
Revert 269271 "Mac Video Capture Device: split VCD into VCD and ..."
> Mac Video Capture Device: split VCD into VCD and Factory.
>
> VideoCaptureDeviceMac includes factory and non-factory parts.
> This CL splits them into VideoCaptureDeviceMac and
> VideoCaptureDeviceFactoryMac. The latter inherits the previous
> class' static methods: Create(), GetDeviceNames() and
> GetDeviceSupportedFormats().
>
> All video factory code previously in MediaStreamManager is
> moved into VideoCaptureFactory. This includes the use
> of the flag |kUseFakeDeviceForMediaStream|.
> This flag is moved correspondingly into media_switches.cc --
> (but note that this flag is still used in MediaStreamManager for
> the Fake Audio parts). File media_switches.cc is
> included in several test files where the flag is used.
>
>
> VideoCaptureDeviceTest is splitted as well into:
> a) Tests that were exercising only the FakeVCD
> (FakeVideoCaptureDeviceTest).
> b) All other tests, that use the underlying OS webcam.
> This VideoCaptureDeviceTest gets a Factory and uses it
> instead of static methods.
>
> A unit test is added to VCDFMac, doing little for the moment
> but I'm planning to add support for testing at least the
> blacklisting -- req from rsesek@ in another CL.
>
> BUG= 288562, 323913, 255552
>
> Review URL: https://codereview.chromium.org/265263004
TBR=mcasas@chromium.org
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269382
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+246 lines, -511 lines) |
Patch |
 |
M |
chrome/browser/apps/speech_recognition_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/apps/web_view_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/chrome_media_stream_infobar_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/chrome_webrtc_audio_quality_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/browser/media/chrome_webrtc_disable_encryption_flag_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
chrome/test/ppapi/ppapi_test.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/media/webrtc_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/media/webrtc_internals_browsertest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/audio_renderer_host_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/media_stream_manager.cc
|
View
|
|
2 chunks |
+19 lines, -5 lines |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/media_stream_manager_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/browser/renderer_host/media/video_capture_host_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/public/common/content_switches.h
|
View
|
|
1 chunk |
+1 line, -0 lines |
0 comments
|
Download
|
 |
M |
content/public/common/content_switches.cc
|
View
|
|
1 chunk |
+3 lines, -0 lines |
0 comments
|
Download
|
 |
M |
content/shell/DEPS
|
View
|
|
1 chunk |
+0 lines, -3 lines |
0 comments
|
Download
|
 |
M |
content/shell/android/browsertests_apk/content_browser_tests_android.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/test/content_test_launcher.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
content/test/webrtc_content_browsertest_base.cc
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
media/base/media_switches.h
|
View
|
|
1 chunk |
+0 lines, -1 line |
0 comments
|
Download
|
 |
M |
media/base/media_switches.cc
|
View
|
|
2 chunks |
+0 lines, -4 lines |
0 comments
|
Download
|
 |
M |
media/media.gyp
|
View
|
|
4 chunks |
+1 line, -9 lines |
0 comments
|
Download
|
 |
D |
media/video/capture/fake_video_capture_device_unittest.cc
|
View
|
|
1 chunk |
+0 lines, -180 lines |
0 comments
|
Download
|
 |
D |
media/video/capture/mac/video_capture_device_factory_mac.h
|
View
|
|
1 chunk |
+0 lines, -34 lines |
0 comments
|
Download
|
 |
D |
media/video/capture/mac/video_capture_device_factory_mac.mm
|
View
|
|
1 chunk |
+0 lines, -125 lines |
0 comments
|
Download
|
 |
D |
media/video/capture/mac/video_capture_device_factory_mac_unittest.mm
|
View
|
|
1 chunk |
+0 lines, -42 lines |
0 comments
|
Download
|
 |
M |
media/video/capture/mac/video_capture_device_mac.h
|
View
|
|
2 chunks |
+8 lines, -9 lines |
0 comments
|
Download
|
 |
M |
media/video/capture/mac/video_capture_device_mac.mm
|
View
|
|
4 chunks |
+95 lines, -19 lines |
0 comments
|
Download
|
 |
M |
media/video/capture/video_capture_device_factory.h
|
View
|
|
1 chunk |
+1 line, -3 lines |
0 comments
|
Download
|
 |
M |
media/video/capture/video_capture_device_factory.cc
|
View
|
|
1 chunk |
+1 line, -37 lines |
0 comments
|
Download
|
 |
M |
media/video/capture/video_capture_device_unittest.cc
|
View
|
|
15 chunks |
+117 lines, -25 lines |
0 comments
|
Download
|
Total messages: 3 (0 generated)
|